Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix build on windows platfrom, use vs2019! #360

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix build on windows platfrom, use vs2019! #360

wants to merge 1 commit into from

Conversation

von500
Copy link

@von500 von500 commented May 24, 2020

when i build project on windows,i find some errors and fixed!

@Waarbubble
Copy link

I would suggest that instead of compiling each library as STATIC that you set BUILD_SHARED_LIBRARY=OFF as the default for windows ie. change line 17 in CMakeLists.txt to:
if(WIN32)
option(BUILD_SHARED_LIBS "Build shared libraries." OFF)
else()
option(BUILD_SHARED_LIBS "Build shared libraries." ON)
endif()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@von500 @Waarbubble